Deprecate DataArray.attrs
#3227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jl-wynen
reviewed
Aug 30, 2023
|
|
||
| def _warn_attr_removal(): | ||
| warnings.warn( | ||
| "sc.DataArray.attrs has been deprecated and will be removed in Scipp v24.12.0. " |
Member
There was a problem hiding this comment.
Do we need to make the period this long? I didn't think we would go longer than 1y.
Member
Author
There was a problem hiding this comment.
By the time we released this... and 2023 is almost over anyway. Do you see any harm in having it this long?
Member
There was a problem hiding this comment.
Not directly. It's just nice to get these things out of the way to simplify the code.
jl-wynen
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simplicity this omits adding warnings to construction of
DataArraywith anattrsargument. Part of #3166.