@jeremiedbb since you have a windows machine where you can build scikit-learn, could you give a try and run the test test_KNeighborsClassifier_raise_on_all_zero_weights to be sure that we don't raise the TypeError?

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: a8dff48. Link to the linter CI: here}

So from the discussion on the feedstock, it seems that this is a rather urgent fix to unblock the migration to NumPy 2.0 on the conda-forge side. I think that it makes sense to make a proper bug fix release (1.4.3) and I'll update the changelog accordingly.

I find that it's a huge waste of time to make a 1.4.3 today or even maybe tomorrow while we'll release 1.5.0 on monday

I tested locally on my windows machine and confirm that it fails without the fix and works with this fix

Please add np.int64 to the list of dtypes in the parametrization of test_all_with_any_reduction_axis_1

I find that it's a huge waste of time to make a 1.4.3 today or even maybe tomorrow while we'll release 1.5.0 on monday

I did not exactly the timeline for the major. But if we release on Monday, I agree.

We can also argue that we should avoid releasing on Friday.

We can also argue that we should avoid releasing on Friday.

That's why I said monday 😄. I aimed to create the release PR tomorrow and try to release on monday

@jeremiedbb I think this is fine to skip adding an entry in the changelog?