Skip to content

DOC Fix time complexity of MLP#28592

Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom
jpienaar-tuks:nn-time-complexity
May 18, 2024
Merged

DOC Fix time complexity of MLP#28592
glemaitre merged 3 commits intoscikit-learn:mainfrom
jpienaar-tuks:nn-time-complexity

Conversation

@jpienaar-tuks
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #27972

What does this implement/fix? Explain your changes.

Update the time complexity formula for neural network backpropagation as described in #27972

Any other comments?

I'm new here, I'd appreciate guidance on anything I should be doing differently.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3075021. Link to the linter CI: here

@adrinjalali
Copy link
Copy Markdown
Member

cc @ogrisel

@jpienaar-tuks jpienaar-tuks changed the title [MRG] Updated time complexity formula in documentation #27972 DOC Updated time complexity formula in documentation #27972 Mar 11, 2024
@glemaitre glemaitre changed the title DOC Updated time complexity formula in documentation #27972 DOC Fix time complexity of MLP May 18, 2024
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I recall that we look together with @ogrisel

@glemaitre glemaitre merged commit d88b413 into scikit-learn:main May 18, 2024
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 20, 2024
Co-authored-by: Johann <jpienaar85@gmail.com>
@jeremiedbb jeremiedbb mentioned this pull request May 20, 2024
14 tasks
jeremiedbb pushed a commit that referenced this pull request May 21, 2024
Co-authored-by: Johann <jpienaar85@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is the time complexity of neural network in the doc right?

3 participants