chore: use dependency-groups#589
Merged
mayeut merged 2 commits intoscikit-build:mainfrom Feb 25, 2025
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
e7d6cdb to
7ca68c9
Compare
mayeut
reviewed
Feb 23, 2025
mayeut
reviewed
Feb 23, 2025
mayeut
reviewed
Feb 23, 2025
mayeut
requested changes
Feb 23, 2025
Contributor
mayeut
left a comment
There was a problem hiding this comment.
The nox build & test sessions were probably already broken as we don't have a workflow for that if I'm not mistaken.
I added a couple suggestions which should fix that (at least on macOS).
It would probably be a good thing to add a dev like workflow in CI ?
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better noxfile, using latest features, too.