MAINT: Remove python3.7 support#217
Merged
bsipocz merged 2 commits intoscientific-python:mainfrom Aug 22, 2023
Merged
Conversation
pllim
approved these changes
Aug 22, 2023
Contributor
pllim
left a comment
There was a problem hiding this comment.
LGTM. But I do wonder if some of the existing Python 3.8 jobs should be bumped to 3.9+ but it is not really in scope here.
Member
Author
I feel it doesn't really matter as those are somewhat redundant anyway, but I can bump them if you like. |
Contributor
|
Up to you. As I said, bumping those are out of scope, and I already approved. 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code changes, except a few very trivial touch-ups. However, there isn't much point develop future enhancements with python 3.7 in mind.