fix: enable race detector for test and fix all detected races#202
Merged
schollz merged 1 commit intoschollz:mainfrom Sep 27, 2024
Merged
fix: enable race detector for test and fix all detected races#202schollz merged 1 commit intoschollz:mainfrom
schollz merged 1 commit intoschollz:mainfrom
Conversation
virtualterm is used in the tests, but is apparently not parallel-safe by itself. Therefore use the progressbar's own lock in test code to guard access to the virtualterm.
Owner
|
Amazing thank you!! |
5 tasks
kodiakhq bot
pushed a commit
to cloudquery/plugin-pb-go
that referenced
this pull request
Oct 14, 2024
…v3 to v3.16.1 (#410)" (#417) This reverts commit b96b6da. #### Summary Looks like this dep update created a data race in the CLI CI so reverting it https://github.com/cloudquery/cloudquery/actions/runs/11330338120/job/31507943884?pr=19381#step:6:2468 Seems like they tried to fix it here schollz/progressbar#202 but might have missed some cases ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virtualterm is used in the tests, but is apparently not parallel-safe by itself. Therefore use the progressbar's own lock in test code to guard access to the virtualterm.
fixes #200