ScalametaParser: fix handling of $x and 'x#4438
Merged
kitbellew merged 1 commit intoscalameta:mainfrom Jan 24, 2026
Merged
Conversation
tgodzik
previously approved these changes
Jan 24, 2026
- `$x` is a splice only within a macro quote; otherwise, an identifier - `'x` is always a quote, regardless whether it's within a macro quote or a macro splice; in scala3, quotes don't introduce symbols anymore. - pass Symbol to MacroQuotedIdent; that way, the compiler immediately detects that this unapply is used after a previous match on Literal and complains about unreachable code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$xis a splice only within a macro quote; otherwise, an identifier'xis always a quote, regardless whether it's within a macro quote or a macro splice; in scala3, quotes don't introduce symbols anymore.