Skip to content

bugfix: Update sbt plugin to correctly publish to maven central#4917

Merged
tgodzik merged 1 commit intoscalameta:mainfrom
tgodzik:update-plugin
May 30, 2025
Merged

bugfix: Update sbt plugin to correctly publish to maven central#4917
tgodzik merged 1 commit intoscalameta:mainfrom
tgodzik:update-plugin

Conversation

@tgodzik
Copy link
Copy Markdown
Contributor

@tgodzik tgodzik commented May 30, 2025

No description provided.

@tgodzik
Copy link
Copy Markdown
Contributor Author

tgodzik commented May 30, 2025

@kitbellew I released the last tag and these changes are needed to fix any future issues

kitbellew
kitbellew previously approved these changes May 30, 2025
Copy link
Copy Markdown
Collaborator

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some questions.

Comment thread build.sbt Outdated
Comment thread project/plugins.sbt
Comment on lines -3 to -5
resolvers ++= Resolver.sonatypeOssRepos("releases")
resolvers ++= Resolver.sonatypeOssRepos("snapshots")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these don't work anymore and there's no central-repo-compliant version, or they were never needed in the first place?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this was ever needed since we don't use snapshot versions of any of the plugins. We can add maven-snapshots to have the same results, but it doesn't add anything currently.

For releases it's basically the same as maven-central

Comment thread build.sbt Outdated
Comment thread build.sbt Outdated
@kitbellew
Copy link
Copy Markdown
Collaborator

formatting check fails, rest are ok.

@tgodzik tgodzik merged commit e1010b7 into scalameta:main May 30, 2025
43 of 44 checks passed
@tgodzik tgodzik deleted the update-plugin branch May 30, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants