Add ErrorMessageID to -Winfer-union warnings (#25073)#25249
Merged
tgodzik merged 1 commit intoscala:mainfrom Feb 11, 2026
Merged
Add ErrorMessageID to -Winfer-union warnings (#25073)#25249tgodzik merged 1 commit intoscala:mainfrom
tgodzik merged 1 commit intoscala:mainfrom
Conversation
Contributor
Author
|
Hi @Gedochao, @eejbyfeldt, |
WojciechMazur
added a commit
that referenced
this pull request
Feb 13, 2026
Fixes #25073 Warnings emitted by `-Winfer-union` previously did not have an ErrorMessageID, which meant they could not be configured using `-Wconf`. This PR: - Introduces `InferUnionWarningID` - Adds structured `InferUnionWarning` message - Updates existing warn tests to include the ID - Adds a new warn test verifying the ID is printed - Adds a neg test verifying `-Wconf:id=E225:error` turns the warning into an error All tests pass. [Cherry-picked f9de300][modified]
WojciechMazur
added a commit
that referenced
this pull request
Feb 14, 2026
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Feb 24, 2026
Fixes scala#25073 Warnings emitted by `-Winfer-union` previously did not have an ErrorMessageID, which meant they could not be configured using `-Wconf`. This PR: - Introduces `InferUnionWarningID` - Adds structured `InferUnionWarning` message - Updates existing warn tests to include the ID - Adds a new warn test verifying the ID is printed - Adds a neg test verifying `-Wconf:id=E225:error` turns the warning into an error All tests pass. [Cherry-picked f9de300][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25073
Warnings emitted by
-Winfer-unionpreviously did not have an ErrorMessageID,which meant they could not be configured using
-Wconf.This PR:
InferUnionWarningIDInferUnionWarningmessage-Wconf:id=E225:errorturns the warning into an errorAll tests pass.