Skip to content

Recognize Nullable annotations in explicit nulls#25237

Merged
noti0na1 merged 3 commits intoscala:mainfrom
dotty-staging:nullable-from-java
Feb 11, 2026
Merged

Recognize Nullable annotations in explicit nulls#25237
noti0na1 merged 3 commits intoscala:mainfrom
dotty-staging:nullable-from-java

Conversation

@noti0na1
Copy link
Copy Markdown
Member

@noti0na1 noti0na1 commented Feb 10, 2026 •
edited
Loading

Rewrite the nullification logic with different modes compared to #21953

Close #25228

@noti0na1 noti0na1 requested a review from Copilot February 10, 2026 20:34

This comment was marked as outdated.

Sign in to view

@noti0na1 noti0na1 requested a review from olhotak February 10, 2026 22:10
@noti0na1
Copy link
Copy Markdown
Member Author

noti0na1 commented Feb 10, 2026

CC @HarrisL2

@noti0na1 noti0na1 marked this pull request as ready for review February 10, 2026 22:11
olhotak
olhotak approved these changes Feb 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarrisL2 also approved (verbally).

@noti0na1 noti0na1 merged commit 3660d53 into scala:main Feb 11, 2026
65 checks passed
@noti0na1 noti0na1 deleted the nullable-from-java branch February 11, 2026 19:15
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Feb 13, 2026
@WojciechMazur WojciechMazur added this to the 3.8.2 milestone Feb 13, 2026
@WojciechMazur WojciechMazur mentioned this pull request Feb 13, 2026
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Feb 13, 2026
WojciechMazur added a commit that referenced this pull request Feb 14, 2026
@WojciechMazur
Backport "Recognize Nullable annotations in explicit nulls" to 3.8.2 (#…
47fd26f 
…25263)

Backports #25237 to the 3.8.2-RC3.

PR submitted by the release tooling.
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@olhotak olhotak olhotak approved these changes

Assignees

No one assigned

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.2

Development

Successfully merging this pull request may close these issues.

Type inference issue for @Nullable Java parameters

5 participants

@noti0na1 @olhotak @tgodzik @WojciechMazur