Skip to content

Pickle CompactAnnotations as regular annotations#25213

Merged
WojciechMazur merged 1 commit intoscala:mainfrom
dotty-staging:fix-25210
Feb 9, 2026
Merged

Pickle CompactAnnotations as regular annotations#25213
WojciechMazur merged 1 commit intoscala:mainfrom
dotty-staging:fix-25210

Conversation

@odersky
Copy link
Copy Markdown
Contributor

@odersky odersky commented Feb 8, 2026

This is needed for forward compatibility in the 3.8 series. We phase in the more efficient encoding in 3.9.

Fixes #25210

@odersky
Pickle CompactAnnotations as regular annotations
b437c4e 
This is needed for forward compatibility in the 3.8 series. We phase in the more
efficient encoding in 3.9.

Fixes scala#25210
@odersky odersky requested a review from WojciechMazur February 8, 2026 18:42
@bracevac
Copy link
Copy Markdown
Contributor

bracevac commented Feb 8, 2026

This is probably going to affect scaladoc for CC again.

@odersky
Copy link
Copy Markdown
Contributor Author

odersky commented Feb 8, 2026

I am not sure. TreeUnpickler is unaffected. We generate CompavctAnnotations from both kinds of pickled info.

@Gedochao
Copy link
Copy Markdown
Contributor

Gedochao commented Feb 9, 2026

@odersky Potentially a minor thing in this case, but are we considering the annotations new API?
If yes, they'd normally have to wait until 3.10 (since we don't have them in 3.8.0 & 3.8.1, if I'm not missing anything).
Do we have strong reasons for having them in 3.8.2/3.9.0?
(sorry to jump on this topic this late, I was out last week)

@odersky
Copy link
Copy Markdown
Contributor Author

odersky commented Feb 9, 2026

The annotations are purely compiler internals. They concern the internal representation of some annotations, not the user facing API.

@Gedochao
Copy link
Copy Markdown
Contributor

Gedochao commented Feb 9, 2026

The annotations are purely compiler internals. They concern the internal representation of some annotations, not the user facing API.

Right, then all should be good, thanks for the clarification. 👍

@WojciechMazur WojciechMazur merged commit f7847cb into scala:main Feb 9, 2026
58 checks passed
@WojciechMazur WojciechMazur deleted the fix-25210 branch February 9, 2026 12:41
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Feb 9, 2026
@WojciechMazur WojciechMazur added this to the 3.8.2 milestone Feb 9, 2026
WojciechMazur pushed a commit that referenced this pull request Feb 10, 2026
@odersky @WojciechMazur
Pickle CompactAnnotations as regular annotations (#25213)
91c5447 
This is needed for forward compatibility in the 3.8 series. We phase in
the more efficient encoding in 3.9.

Fixes #25210
[Cherry-picked f7847cb]
@WojciechMazur WojciechMazur mentioned this pull request Feb 10, 2026
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Feb 10, 2026
WojciechMazur pushed a commit that referenced this pull request Feb 10, 2026
@odersky @WojciechMazur
Pickle CompactAnnotations as regular annotations (#25213)
ae466ad 
This is needed for forward compatibility in the 3.8 series. We phase in
the more efficient encoding in 3.9.

Fixes #25210
[Cherry-picked f7847cb]
WojciechMazur added a commit that referenced this pull request Feb 10, 2026
@WojciechMazur
Backport "Pickle CompactAnnotations as regular annotations" to 3.8.2 (#…
d593d3f 
…25223)

Backports #25213 to the 3.8.2-RC2.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WojciechMazur WojciechMazur WojciechMazur approved these changes

Assignees

@WojciechMazur WojciechMazur

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.2

Development

Successfully merging this pull request may close these issues.

Broken TASTy compatibility between 3.8.1 and 3.8.2-RC1

5 participants

@odersky @bracevac @Gedochao @WojciechMazur @tgodzik