Avoid NPE when calling hashCode on a value class wrapping null#25110
Merged
lrytz merged 1 commit intoscala:mainfrom Jan 27, 2026
Merged
Avoid NPE when calling hashCode on a value class wrapping null#25110lrytz merged 1 commit intoscala:mainfrom
lrytz merged 1 commit intoscala:mainfrom
Conversation
Change the synthetic hashCode for value classes from def hashCode(): Int = this.underlying.hashCode to def hashCode(): Int = java.util.Objects.hashCode(this.underlying) (unless the underlying value is primitive) Forward-port of scala/scala#11204
sjrd
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the synthetic hashCode for value classes from
to
(unless the underlying value is primitive)
Forward-port of scala/scala#11204