fix: add missing specialized method in NumericRange#25020
Merged
hamzaremmal merged 1 commit intoscala:mainfrom Jan 21, 2026
Merged
fix: add missing specialized method in NumericRange#25020hamzaremmal merged 1 commit intoscala:mainfrom
hamzaremmal merged 1 commit intoscala:mainfrom
Conversation
8bc8307 to
5fc3dd5
Compare
hamzaremmal
commented
Jan 20, 2026
Member
Author
There was a problem hiding this comment.
We should keep in mind the following #22524. Potentially, this test might be useless.
sjrd
approved these changes
Jan 20, 2026
Comment on lines
+4
to
+7
| lazy val lib = project.in(file("lib")) | ||
| .settings( | ||
| scalaVersion := scala2Version | ||
| ) |
Contributor
There was a problem hiding this comment.
Potentially all of these tests can be moved to sbt-test/scala2-compat/i24998 which does also enabled optimizations on the Scala 2 library
Mostly an optimization, since scripted tests are typically quite expensive
Contributor
|
The scaladoc failure is unrelated to this change, but rather to the #24963 - I'm not sure why it was not activated earlier in the CI (I've seen in the 3.8.1-RC1 branch though during backports earlier) Scaladoc CI fix is now in main #25022 |
Member
Author
|
rebasing so that the scaladoc failure passes. |
5fc3dd5 to
f911306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When porting the scala 2 side of the library, the following method was not detected by any of our tools and was missing.