Try to fix callee type inference in typedFunctionValue#24732
Merged
noti0na1 merged 1 commit intoscala:mainfrom Dec 12, 2025
Merged
Try to fix callee type inference in typedFunctionValue#24732noti0na1 merged 1 commit intoscala:mainfrom
noti0na1 merged 1 commit intoscala:mainfrom
Conversation
Member
Author
|
The last commit contains the stricter rule we discussed yesterday, but it breaks type inference in several tests. @odersky |
9b730ab to
8671e84
Compare
Contributor
|
I fixed calleetype so that all tests pass, except for three tests that tested recent regressions. We should look separately into these. They probably need another fix. |
Member
Author
The remaining errors should be fixed after we merge #24697 |
noti0na1
added a commit
that referenced
this pull request
Dec 12, 2025
This PR refines the `TypeVar` instantiation logic introduced by #24231. We only check the `calleeType` when there is actually a `TypeVar` in `pt` to instantiate now, prioritizing inference from the callee. Close #24686 #24689 #24694 #24696 Maybe #24695, since the behaviour is the same as 3.3 and 3.7 now. `calleeType` itself still has some issues, will fix in a separate PR: #24732
This one will bring back previously fixed regressions that have to be looked at separately.
8671e84 to
cbdf29b
Compare
Member
Author
|
Rebased on top of main branch |
odersky
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callee part is separated from #24697 for further investigation
When typing a function literal's expression to infer the callee type, we now create placeholder tree for each argument, and make sure the function part does not refer to any parameter. This ensures that references in the expression won't incorrectly resolve to outer scope variables with the same names as the parameters.
Fix the following test: