Work around sbt#8376 and re-enable shapeless-3 community build#24709
Work around sbt#8376 and re-enable shapeless-3 community build#24709Gedochao merged 1 commit intoscala:mainfrom
sbt#8376 and re-enable shapeless-3 community build#24709Conversation
sbt#8376 and re-enable shapeless-3 community build
| publishLocalConfiguration ~= (_.withOverwrite(true)), | ||
| projectID ~= {id => | ||
| val line = "scala.versionLine" -> versionLine | ||
| val line = "info.scala.versionLine" -> versionLine |
There was a problem hiding this comment.
I haven't seen any usages of that so far in any OSS tooling. It would definitely would be something to announce in release notes.
There was a problem hiding this comment.
When was it added actually? I had no idea there was anything like that available 😅
Also how will it work for 3.9? Would we set it to next or LTS? Doesn't seem altogether that useful
There was a problem hiding this comment.
at a glance, we should be ok to do this.
if there's some obscure usage somewhere, we should catch it during RC.
There was a problem hiding this comment.
We commented almost simultanously 😅
When was it added actually? I had no idea there was anything like that available 😅
git blame says 26.03.2024
Also how will it work for 3.9? Would we set it to next or LTS? Doesn't seem altogether that useful
This is a good question... I'd say it would be LTS for 3.9 line. We shouldn't consider 3.9.0 LTS even for the brief moment when it's the newest version (content-wise, it wouldn't be very different from another patch in 3.8). 3.10.0 would follow soon after.
I guess we'll discuss it on a future Scala Core.
There was a problem hiding this comment.
@tgodzik it seems we've had it since Scala 3.4.2, but it wasn't widely known, since we seemingly didn't mention it in the release notes 😅
- release notes: https://github.com/scala/scala3/releases/tag/3.4.2
- actually added here: Add
versionLinemarker to pom.xml #19986 - modified here, also 3.4.2: Avoid duplications of properties in pom.xml #20020
There was a problem hiding this comment.
I had planed to used it in Scala Steward.... but that didn't happen, yet. 😄
scala-steward-org/scala-steward#3328
|
Looks like it could be used for Scala Steward, but currently it's not scala-steward-org/scala-steward#3328 |
…24709) - works around sbt/sbt#8376 / coursier/coursier#3520 - kudos to @eed3si9n for suggesting this, as per coursier/coursier#3520 (comment) - re-enables tests disabled in #24477 (comment) [Cherry-picked 577721f]
…24709) - works around sbt/sbt#8376 / coursier/coursier#3520 - kudos to @eed3si9n for suggesting this, as per coursier/coursier#3520 (comment) - re-enables tests disabled in #24477 (comment) [Cherry-picked 577721f]
…cala#24709) - works around sbt/sbt#8376 / coursier/coursier#3520 - kudos to @eed3si9n for suggesting this, as per coursier/coursier#3520 (comment) - re-enables tests disabled in scala#24477 (comment) [Cherry-picked 577721f]
-Yno-stdlib-patches#24477 (comment)