Improve TypeVar instantiation logic#24697
Merged
noti0na1 merged 1 commit intoscala:mainfrom Dec 12, 2025
Merged
Conversation
This was
linked to
issues
Dec 8, 2025
…ed when there exists a TypeVar in pt
36dc33a to
dc3281e
Compare
odersky
approved these changes
Dec 12, 2025
noti0na1
added a commit
that referenced
this pull request
Dec 12, 2025
The callee part is separated from #24697 for further investigation When typing a function literal's expression to infer the callee type, we now create placeholder tree for each argument, and make sure the function part does not refer to any parameter. This ensures that references in the expression won't incorrectly resolve to outer scope variables with the same names as the parameters. Fix the following test: ```scala def foo[T <: (B => Unit)](f: T) = ??? def transfer(in: A): Unit = foo(in => transfer(in)) // error: Found: (in : B) Required: A def transfer(in: B): Unit = ??? ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the
TypeVarinstantiation logic introduced by #24231.We only check the
calleeTypewhen there is actually aTypeVarinptto instantiate now, prioritizing inference from the callee.Close #24686 #24689 #24694 #24696
Maybe #24695, since the behaviour is the same as 3.3 and 3.7 now.
calleeTypeitself still has some issues, will fix in a separate PR: #24732