Dealias type of type constructor in typedAppliedTypeTree#24522
Merged
odersky merged 1 commit intoscala:mainfrom Nov 25, 2025
Merged
Dealias type of type constructor in typedAppliedTypeTree#24522odersky merged 1 commit intoscala:mainfrom
typedAppliedTypeTree#24522odersky merged 1 commit intoscala:mainfrom
Conversation
hamzaremmal
reviewed
Nov 25, 2025
| typed(tree.tpt, AnyTypeConstructorProto) | ||
|
|
||
| val tparams = tpt1.tpe.typeParams | ||
| val tparams = tpt1.tpe.dealiasKeepAnnotsAndOpaques.typeParams |
Member
There was a problem hiding this comment.
I've been playing with some examples. In all of them, typeParams was able to return the actual typeParams but the top level case (the issue this tries to solve) without the dealiasing. Which means that in the contract of typeParams, it should be able to return the actual params without dealiasing at all. I think it's still worth investigating and fixing such that we don't need the dealiasing here.
odersky
approved these changes
Nov 25, 2025
Contributor
odersky
left a comment
There was a problem hiding this comment.
If it passes the tests, it should be OK.
Contributor
|
Looks like backporting this change to LTS doesn't allow the tests to pass. We would need a separate fix on LTS 3.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23752.