Skip to content

Wshadow option recognizes Wall#24469

Merged
tgodzik merged 1 commit intoscala:mainfrom
som-snytt:issue/24466-wall
Nov 20, 2025
Merged

Wshadow option recognizes Wall#24469
tgodzik merged 1 commit intoscala:mainfrom
som-snytt:issue/24466-wall

Conversation

@som-snytt
Copy link
Copy Markdown
Contributor

@som-snytt som-snytt commented Nov 18, 2025

Fixes #24466

@som-snytt som-snytt marked this pull request as ready for review November 18, 2025 12:04
@Gedochao Gedochao requested a review from tgodzik November 19, 2025 09:07
tgodzik
tgodzik approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit cad0d2a into scala:main Nov 20, 2025
83 of 84 checks passed
@som-snytt som-snytt deleted the issue/24466-wall branch November 20, 2025 15:25
@WojciechMazur WojciechMazur added this to the 3.8.1 milestone Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees

@tgodzik tgodzik

Labels

None yet

Projects

None yet

Milestone

3.8.2

Development

Successfully merging this pull request may close these issues.

Option -Wall is inconsistent with -Wshadow and -Wunused

4 participants

@som-snytt @tgodzik @Kordyjan @WojciechMazur