Don't crash when update is used as a modifier outside cc#24378
Merged
hamzaremmal merged 1 commit intoscala:mainfrom Nov 12, 2025
Merged
Don't crash when update is used as a modifier outside cc#24378hamzaremmal merged 1 commit intoscala:mainfrom
hamzaremmal merged 1 commit intoscala:mainfrom
Conversation
We now treat update like erased and consume. The error message is still not great, maybe something can be done about that.
Member
|
Relates to #24371 |
hamzaremmal
approved these changes
Nov 12, 2025
Member
hamzaremmal
left a comment
There was a problem hiding this comment.
Note that this work because we revive a dead path in the Scanner.
scala3/compiler/src/dotty/tools/dotc/parsing/Scanners.scala
Lines 1228 to 1234 in 32bfd5f
Before, we matched in line 1230 but now we will match in line 1233.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now treat update like erased and consume. The error message is still not great, maybe something can be done about that.