Fix regression: Prioritize tree type over proto type when typing Binds#24175
Merged
odersky merged 2 commits intoscala:mainfrom Nov 2, 2025
Merged
Conversation
72fcb5b to
8dd34d2
Compare
8dd34d2 to
901744a
Compare
odersky
approved these changes
Nov 2, 2025
Contributor
odersky
left a comment
There was a problem hiding this comment.
Nice analysis leading to super-simple fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24038
In the minimisation, the typer phase expanded
into
Before the change in #23923 it would simplify
((T, M[T]) & (h *: t, bh *: bt))into(T & (h *: t), M[T] & (bh *: bt))and thus generate:Since it looks like this simplification is now illegal, and the unapply generation for intersection types seems to prioritize the leftmost argument, to fix this we make sure that when typing Binds we prioritize the user-created
tree.tpeand deprioritize the inferred proto type, which hopefully is enough.