Skip to content

Discard scala.caps.Pure in the erasure of union and intersection types#24151

Merged
sjrd merged 1 commit intoscala:mainfrom
hamzaremmal:erasure-pure
Oct 10, 2025
Merged

Discard scala.caps.Pure in the erasure of union and intersection types#24151
sjrd merged 1 commit intoscala:mainfrom
hamzaremmal:erasure-pure

Conversation

@hamzaremmal
Copy link
Copy Markdown
Member

@hamzaremmal hamzaremmal commented Oct 8, 2025

Since CC should not be visible in the binary code in general, and as a workaround for #24113 and #24148, we treat specially the erasure of A & Pure and if Pure appears in the base classes when erasing A | B

Closes #23882

@hamzaremmal hamzaremmal changed the title Discard scala.caps.Pure in the erasure of union and intersection types Discard scala.caps.Pure in the erasure of union and intersection types Oct 8, 2025
@hamzaremmal hamzaremmal marked this pull request as ready for review October 8, 2025 17:20
@hamzaremmal hamzaremmal requested review from odersky and sjrd October 8, 2025 17:20
odersky
odersky approved these changes Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code could be simplified in two places. Otherwise LGTM.

@hamzaremmal
Copy link
Copy Markdown
Member Author

hamzaremmal commented Oct 8, 2025

I will wait for @sjrd's review too before merging this.

@sjrd sjrd merged commit dfb29d5 into scala:main Oct 10, 2025
51 checks passed
@sjrd
Copy link
Copy Markdown
Member

sjrd commented Oct 11, 2025 •
edited
Loading

The test fails on Windows, apparently:

Output from 'tests\run\i23882.scala' did not match check file. Actual output:
public void Foo.foo(java.lang.Object)
public void Foo.foo(scala.Equals)
public void Foo.bar2(Bar)
public void Foo.bar4(Bar)
public void Foo.bar3(Bar)
public void Foo.bar(Bar)


Test output dumped in: tests\run\i23882.check.out
  See diff of the checkfile (`--color=always` for colored diff)
    > git diff --no-index -- tests\run\i23882.check tests\run\i23882.check.out
  Replace checkfile with current output
    > mv tests\run\i23882.check.out tests\run\i23882.check

It looks like we should sort the result for stability.

@hamzaremmal hamzaremmal deleted the erasure-pure branch October 12, 2025 01:42
@noti0na1
Copy link
Copy Markdown
Member

noti0na1 commented Oct 12, 2025

We should get the declaired methods in a given order, similar in #24129

@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odersky odersky odersky approved these changes

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

@odersky odersky

Labels

None yet

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

Union type triggers conflictings definitions after erasure but normal generic argument does not

7 participants

@hamzaremmal @sjrd @noti0na1 @odersky @tgodzik @Kordyjan @WojciechMazur