Skip to content

Scala.js: Add JS-specific version of VarArgsBuilder.#24144

Merged
odersky merged 1 commit intoscala:mainfrom
dotty-staging:sjs-js-varargsbuilder
Oct 10, 2025
Merged

Scala.js: Add JS-specific version of VarArgsBuilder.#24144
odersky merged 1 commit intoscala:mainfrom
dotty-staging:sjs-js-varargsbuilder

Conversation

@sjrd
Copy link
Copy Markdown
Member

@sjrd sjrd commented Oct 7, 2025

It follows the model of regular varargs, which also use a linkTimeIf-based dispatch in scala.scalajs.runtime.to*VarArgs.

See https://github.com/scala-js/scala-js/blob/4d538a13a81ff04258a0af8568daa60f83e82b13/library/src/main/scala/scala/scalajs/runtime/package.scala#L31-L87 for context in scala-js/scala-js.

It follows the model of regular varargs, which also use a
`linkTimeIf`-based dispatch in `scala.scalajs.runtime.to*VarArgs`.
@sjrd sjrd requested a review from odersky October 7, 2025 14:00
@sjrd sjrd requested a review from a team as a code owner October 7, 2025 14:00
@odersky odersky merged commit 392d0a7 into scala:main Oct 10, 2025
51 checks passed
@odersky odersky deleted the sjs-js-varargsbuilder branch October 10, 2025 17:56
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants