Skip to content

No mixin forwarder when ancestor is sealed#23482

Merged
hamzaremmal merged 1 commit intoscala:mainfrom
som-snytt:issue/23479-sealing
Oct 1, 2025
Merged

No mixin forwarder when ancestor is sealed#23482
hamzaremmal merged 1 commit intoscala:mainfrom
som-snytt:issue/23479-sealing

Conversation

@som-snytt
Copy link
Copy Markdown
Contributor

@som-snytt som-snytt commented Jul 6, 2025 •
edited
Loading

Fixes #23479

Adds check for Java sealed ancestor to needsMixinForwarder.

If it's ok to invokespecial an indirect superinterface, then the fix should be in the backend, to not add the interface parent.

@som-snytt som-snytt force-pushed the issue/23479-sealing branch 5 times, most recently from a85d7c5 to 726e081 Compare July 7, 2025 16:35
@som-snytt
Copy link
Copy Markdown
Contributor Author

som-snytt commented Jul 7, 2025

Not settled on the solution, but added // scalajs: --skip.

@som-snytt
Copy link
Copy Markdown
Contributor Author

som-snytt commented Jul 7, 2025

Looking into a Scala 2 issue, JVM spec says

• Each invokespecial instruction must name one of the following:
– an instance initialization method (§2.9.1)
– a method in the current class or interface
– a method in a superclass of the current class
– a method in a direct superinterface of the current class or interface
– a method in Object

by which I understand direct superinterface to mean the forwarder won't work if not implementing the superinterface.

@som-snytt
Copy link
Copy Markdown
Contributor Author

som-snytt commented Jul 10, 2025

Flaky:

[error] Could not create file /__w/scala3/scala3/community-build/community-projects/Equal/jvm/target/streams/_global/ivySbt/_global/streams/outjava.io.IOException: No such file or directory

@som-snytt som-snytt force-pushed the issue/23479-sealing branch from 726e081 to 282435d Compare July 11, 2025 21:45
@som-snytt som-snytt marked this pull request as ready for review July 11, 2025 21:54
@Gedochao Gedochao requested a review from hamzaremmal July 14, 2025 09:26
@som-snytt som-snytt force-pushed the issue/23479-sealing branch from 282435d to 249f8d9 Compare August 9, 2025 00:16
@PhoenixmitX
Copy link
Copy Markdown

PhoenixmitX commented Aug 10, 2025

@hamzaremmal Do you have an ETA for when you will have time to review this?

@hamzaremmal
Copy link
Copy Markdown
Member

hamzaremmal commented Aug 14, 2025

@hamzaremmal Do you have an ETA for when you will have time to review this?

I'm quite busy with some urgent work. I'll probably review it after Scala Days 2025. Regardless, it will be included in 3.8.0.

@hamzaremmal
Copy link
Copy Markdown
Member

hamzaremmal commented Sep 26, 2025

@som-snytt can you please rebase on top of the latest commit in main.

@hamzaremmal hamzaremmal merged commit e914efe into scala:main Oct 1, 2025
49 checks passed
@som-snytt som-snytt deleted the issue/23479-sealing branch October 1, 2025 13:16
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Oct 28, 2025
@tgodzik tgodzik mentioned this pull request Nov 5, 2025
Merged
@PhoenixmitX PhoenixmitX mentioned this pull request Feb 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

Assignees

@hamzaremmal hamzaremmal

Labels

None yet

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

Runtime errors when implementing non-sealed java interface

6 participants

@som-snytt @PhoenixmitX @hamzaremmal @tgodzik @Kordyjan @WojciechMazur