Merged
Conversation
Rename the `mut` soft modifier to `update`. Reasons: - `update` is more descriptive than `mut` - `update` corresponds to the terminology "update method" - 3 letter modifiers are problematic for visual layout
bracevac
reviewed
Jun 9, 2025
Contributor
bracevac
left a comment
There was a problem hiding this comment.
- Also update the exclusive capabilities design doc?
- If we have
updatemethods now, why is it that we still extend from a thing namedMutable? Should it consequently not beUpdatable(which sounds weird). So maybe something more neutral such asResource, orExclusivein line with the title of the design doc?
Contributor
Author
|
I think it's "update methods work on a mutable data structure". There is a difference between the method and the data. |
bracevac
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the
mutsoft modifier toupdate.Reasons:
updateis more descriptive thanmutupdatecorresponds to the terminology "update method"