Fix SemantiDB production of method signature with shadowed parameters#23161
Merged
tgodzik merged 2 commits intoscala:mainfrom May 22, 2025
Merged
Conversation
natsukagami
reviewed
May 19, 2025
Contributor
natsukagami
left a comment
There was a problem hiding this comment.
Just one comment about the condition, otherwise looks good, tests are passing as well.
natsukagami
approved these changes
May 20, 2025
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
May 26, 2025
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
May 26, 2025
…scala#23161) [Cherry-picked 3080a70][modified]
EnzeXing
pushed a commit
to EnzeXing/dotty
that referenced
this pull request
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23160
The problem was caused by the way we populated the paramRefSymtab in TypeOps.scala.
In #23160 when looking at val x, we will enterParamRef of its owner which is foo. However foo also has a param with name x so it will enter the symbol of the val x in the paramRefSymTab which is incorrect.
We therefore must make sure the symbol is a param to be entered if it's owner was a method.
New test cases were added to confirm the fix.