Merged
Conversation
tgodzik
approved these changes
May 2, 2025
Contributor
tgodzik
left a comment
There was a problem hiding this comment.
LGTM though the code actions do not show up unless the rewrite flag is on. At that point rewrites are doing all the job, so actions are not really needed.
Would it make sense to always produce the actions, just not act on them unless rewrite is on?
Contributor
Author
|
Yes, I remember I was unsure about the UX. I suppose asking for warnings means asking for code actions (which may be a bit expensive to calculate, but the lint is already expensive). (I was also concerned that |
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
May 5, 2025
Left less vertical space when deleting lines of import. Extracted from local branch of scala#22316 [Cherry-picked 0ae343f]
odersky
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
May 12, 2025
Left less vertical space when deleting lines of import. Extracted from local branch of scala#22316
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Left less vertical space when deleting lines of import.
Extracted from local branch of #22316