Option warnings are conditional#13915
Conversation
|
Did not yet investigate how to set up an automated test. |
|
Are all the configuration messages about such trivial matters like setting the flag twice? If so, then I agree this is the right change. But if there are any that are more concerning, then I think it would be wrong to hide them away by default. |
|
For instance, setting the output flag twice is by-default warning worthy imo. If I set |
|
Yes, my first thought was to distinguish In Scala 2, there was discussion around "last setting wins" semantics. But really a warning is warranted, especially because the context is not a command line in a script, where you might want to just make a best effort, but possibly multiple plugins adding options. |
56cfaad to
98845ef
Compare
dwijnand
left a comment
There was a problem hiding this comment.
LGTM. Ready for this to be merged, @som-snytt?
|
Overall, I thought A few observations, it warns on but not The flag warning sounds flippant. On It does not warn on |
740fc6e to
e2a9823
Compare
|
Rebased and added warning on multiple outputs. Also implicit |
|
e2a9823 to
34cb904
Compare
|
Rebased hoping to duck spurious test failures. |
34cb904 to
700d6f8
Compare
|
Accidentally used jdk 11 |
|
Rebased hoping never to have to rebase again. Conflict in settings, of course. Now that I know about There is a separate effort for tests to respect I saw in the settings conflict that |
|
Also, may you live in interesting times. and come to know interesting people. |
|
It looks like this is ready but waiting on a final look by @dwijnand ? I've assigned him and given @som-snytt write privileges in this repo so he can assign people himself. |
|
Apologies in advance, Dale. I see a few style nits, so I will take a quick pass over it. I already checked my white privilege. Oh, it says "write" privilege. |
dwijnand
left a comment
There was a problem hiding this comment.
LGTM, except the option name...
27cdc6d to
76f6d86
Compare
|
@KacperFKorban Maybe you have time to review the refactor of Settings that improves the remaining arguments in the setting state when erroring. There were a couple of fixes in August when I rebased (tweak arg handling in The original feature was to add a |
76f6d86 to
e4b99cb
Compare
|
@Gedochao Thank-you! I was listening to entertainment media while adding the "deprecated aliases" commit. Would you care to comment? Or I could move it to a separate PR. I also cleaned up the test per review. |
Gedochao
left a comment
There was a problem hiding this comment.
About the actual alias deprecations.
Yup, separate PR would be preferable. |
4f23c3d to
7c0539c
Compare
|
@WojciechMazur we'd need to backport this to 3.8 if we'd backport #24359 |
Backports #13915 to the 3.8.0-RC1. PR submitted by the release tooling. [skip ci]
|
Looks like too many changes to the settings were not backported, which means we would need to reimplement it for LTS. Skipping backport for now. |
Fixes #13887