[Indented syntax improvements] Dart implementation#2467
Merged
Conversation
…d-syntax-improvements
…d-syntax-improvements
jamesnw
commented
Jan 2, 2025
Contributor
Author
jamesnw
left a comment
There was a problem hiding this comment.
@nex3 This is ready for another round of review, along with the spec draft 1.2. Thanks!
nex3
requested changes
Jan 3, 2025
jamesnw
commented
Jan 3, 2025
Contributor
Author
jamesnw
left a comment
There was a problem hiding this comment.
@nex3 Changes made. I also have an outstanding question here- https://github.com/sass/dart-sass/pull/2467/files/38e05bf45a34f175921f5be1d8efbf4ab2c54a9a#r1896194128
…d-syntax-improvements
nex3
approved these changes
Jan 29, 2025
| * **Potentially breaking bug fix**: Selectors with unmatched brackets now always | ||
| produce a parser error. Previously, some edge cases like `[foo#{"]:is(bar"}) {a: | ||
| b}` would compile without error, but this was an unintentional bug. | ||
| ## 1.83.5-dev |
Contributor
Author
Contributor
|
Holding off on merging this until #2505 lands so it can get into the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked until proposal is accepted.
[skip sass-embedded]