Skip to content

refactor: remove helpers deprecated for more than 3y#810

Merged
samber merged 1 commit intomasterfrom
refactor/remove-old-deprecation
Feb 22, 2026
Merged

refactor: remove helpers deprecated for more than 3y#810
samber merged 1 commit intomasterfrom
refactor/remove-old-deprecation

Conversation

@samber
Copy link
Owner

@samber samber commented Feb 22, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 22, 2026 04:13
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (c70160e) to head (628e61d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   92.05%   92.25%   +0.19%     
==========================================
  Files          32       32              
  Lines        4216     4208       -8     
==========================================
+ Hits         3881     3882       +1     
+ Misses        256      247       -9     
  Partials       79       79              
Flag Coverage Δ
unittests 92.25% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samber samber merged commit 86e5d8b into master Feb 22, 2026
14 of 15 checks passed
@samber samber deleted the refactor/remove-old-deprecation branch February 22, 2026 04:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes deprecated helper functions that have been marked as deprecated for more than 3 years. The changes clean up the codebase by removing wrapper functions that were kept for backward compatibility but are no longer needed.

Changes:

  • Removed Elipse function from string.go (typo/deprecated alias for Ellipsis)
  • Removed Batch, BatchWithTimeout, and ChannelMerge functions from channel.go (deprecated aliases for Buffer, BufferWithTimeout, and FanIn respectively)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
string.go Removes the deprecated Elipse function, a misspelled alias for Ellipsis
channel.go Removes three deprecated channel helper functions: Batch (alias for Buffer), BatchWithTimeout (alias for BufferWithTimeout), and ChannelMerge (alias for FanIn)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants