Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 94.26% 94.30% +0.04%
==========================================
Files 18 18
Lines 2860 2969 +109
==========================================
+ Hits 2696 2800 +104
- Misses 149 153 +4
- Partials 15 16 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request applies linter fixes across the codebase to ensure compliance with enabled linters (godot, thelper, gocyclo, and revive).
Changes:
- Added missing period to godoc comment and
t.Helper()call in test helper function - Removed unnecessary
//nolint:gocyclodirectives from functions now under complexity threshold - Added
//nolint:revivedirectives to intentional empty for-range loops in benchmarks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| it/lo_test.go | Fixed godoc comment punctuation and added t.Helper() call to test helper function |
| it/intersect.go | Removed gocyclo nolint directives from Intersect and IntersectBy functions |
| benchmark/seq_benchmark_test.go | Added revive nolint directives to suppress warnings for intentional empty benchmark loops |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.