bench: fix iterators to actually iterate in benchmarks#781
Merged
samber merged 1 commit intosamber:masterfrom Jan 26, 2026
Merged
bench: fix iterators to actually iterate in benchmarks#781samber merged 1 commit intosamber:masterfrom
samber merged 1 commit intosamber:masterfrom
Conversation
- Consume iterators with for range instead of discarding with _ = Previously iterators were created but never consumed, giving misleading performance results (~0.3 ns/op) that only measured iterator creation - Add BenchmarkItDropLastWhile for testing DropLastWhile performance - Add BenchmarkItTrim for testing Trim performance - Add BenchmarkItTrimSuffix for testing TrimSuffix performance - Replace for better readability `for i := 0; i < n; i++` with `for i := range n` This fix ensures benchmarks measure actual iterator execution time rather than just iterator creation time, which is critical for lazy iterators that don't execute until consumed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
=======================================
Coverage 94.18% 94.18%
=======================================
Files 18 18
Lines 2872 2872
=======================================
Hits 2705 2705
Misses 151 151
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for i := 0; i < n; i++withfor i := range nThis fix ensures benchmarks measure actual iterator execution time rather than just iterator creation time, which is critical for lazy iterators that don't execute until consumed.