perf: replace Min/Max(Range) with Min/MaxIndexBy in DispatchingStrategy#779
Merged
samber merged 1 commit intosamber:masterfrom Feb 8, 2026
Merged
Conversation
- Replace Range+MinBy with MinIndexBy in DispatchingStrategyLeast for better performance - Replace Range+MaxBy with MaxIndexBy in DispatchingStrategyMost for better performance - Use range loop in DispatchingStrategyWeightedRandom for better readability - Simplify Buffer function by using local variable in for loop and returning size directly These changes reduce allocations and improve performance by using more efficient index-finding functions instead of creating intermediate slices with Range().
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
==========================================
- Coverage 94.18% 94.18% -0.01%
==========================================
Files 18 18
Lines 2872 2871 -1
==========================================
- Hits 2705 2704 -1
Misses 151 151
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes reduce allocations and improve performance by using more efficient index-finding functions instead of creating intermediate slices with Range().