perf: only allocate a single map in Intersect#736
Merged
samber merged 5 commits intosamber:masterfrom Nov 6, 2025
Merged
Conversation
This will ignore the ordering of the final intersection. Especially important when checking old versions of go that do not guarantee an order when iterating through maps.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 94.15% 94.25% +0.09%
==========================================
Files 18 18
Lines 2789 2801 +12
==========================================
+ Hits 2626 2640 +14
+ Misses 148 147 -1
+ Partials 15 14 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samber
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#181 recently improved the
lo.Intersecthelper by making it variadic, an improvement I had also made to theit.Intersectversion. This PR "aligns" the two implementations so that the slice version only allocates a single map instead of N+1 maps.