lint: fix inconsistent callback function parameter names#730
Merged
samber merged 8 commits intosamber:masterfrom Nov 6, 2025
Merged
lint: fix inconsistent callback function parameter names#730samber merged 8 commits intosamber:masterfrom
samber merged 8 commits intosamber:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 94.22% 94.18% -0.04%
==========================================
Files 18 18
Lines 2805 2805
==========================================
- Hits 2643 2642 -1
- Misses 148 149 +1
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This will ignore the ordering of the final intersection. Especially important when checking old versions of go that do not guarantee an order when iterating through maps.
e63cedc to
16cc9d7
Compare
samber
approved these changes
Nov 6, 2025
Owner
|
I also added: #738 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite a few callback function parameters are incorrectly named. This PR attempts to fix a few of these. This is something I noticed whilst building the
itsubpackage.There are always exceptions but...
Also, I've never seen the word "iteratee" used anywhere else before (as a native English speaker). I would propose renaming them all to something more meaningful.