Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
==========================================
- Coverage 94.48% 94.45% -0.03%
==========================================
Files 18 18
Lines 3429 3411 -18
==========================================
- Hits 3240 3222 -18
Misses 175 175
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
I'm pretty sure there is no difference in final asm code. Go compiler inlines such methods when no side effect is detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 4 intersect helpers that could benefit from using the existing
Keyifyhelper internally.This is a question I have quite often whilst working on iterators support - when is it appropriate to use another helper and when is it better to implement from scratch?
There are lots of places where simple helpers like
EmptyorMapor evenTernarycould be used. What about related helpers like likeCountusingCountByinternally, etc?