Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## rel-0.101 #149 +/- ##
==========================================
Coverage 94.75% 94.75%
==========================================
Files 15 15
Lines 3432 3432
==========================================
Hits 3252 3252
Misses 180 180
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Aug 8, 2023
In 0.101.2 we deprecated the `TlsServerTrustAnchors` and `TlsClientTrustAnchors` types along with the `EndEntity::verify_is_valid_tls_server_cert` and `EndEntity::verify_is_valid_tls_client_cert` functions that used them. However, only the `EndEntity` deprecations had a `note` pointing to the preferred replacement, and the text was quite terse. This commit adds notes to the trust anchor types that were missing these, and updates the end entity verification deprecation notes to be more user-friendly.
6796c4f to
f3b66e9
Compare
ctz
approved these changes
Aug 8, 2023
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.101.3 release prep
This branch (that I should have named more generally, in retrospect) targets a base of
rel-0.101, created from the v0.101.2 tag.The deprecations mentioned in #148 were in the released 0.101.2, but
mainhas already removed the deprecated elements. In order to improve the deprecation notes we'll need to start a release branch. I've gone ahead and done that roughly following the rustls guidance.Proposed release notes
TlsServerTrustAnchors,TlsClientTrustAnchors,verify_is_valid_tls_server_certandverify_is_valid_tls_client_certdeprecation notes improved.trust_anchor/end_entity: rework deprecation notes.
In 0.101.2 we deprecated the
TlsServerTrustAnchorsandTlsClientTrustAnchorstypes along with theEndEntity::verify_is_valid_tls_server_certandEndEntity::verify_is_valid_tls_client_certfunctions that used them.However, only the
EndEntitydeprecations had anotepointing to the preferred replacement, and the text was quite terse.This commit adds notes to the trust anchor types that were missing these, and updates the end entity verification deprecation notes to be more user-friendly.
Thanks to @jsha for pointing out the omission in #148
Cargo: version 0.101.2 -> 0.101.3
Bumps the Cargo version for the release.