crl/signed_data: add Debug and Clone as sensible.#129
Merged
cpu merged 2 commits intorustls:mainfrom Jul 19, 2023
Merged
Conversation
This commit adds derived `Debug` traits to: * `BorrowedCertRevocationList` * `BorrowedRevokedCert` * `RevokedCerts` * `SignedData` * `OwnedCertRevocationList` * `OwnedRevokedCert` * `OwnedSignedData` It additionally adds derived `Clone` traits to: * `OwnedCertRevocationList` * `OwnedRevokedCert` * `OwnedSignedData`
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 95.69% 95.73% +0.04%
==========================================
Files 15 15
Lines 3346 3379 +33
==========================================
+ Hits 3202 3235 +33
Misses 144 144
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Jul 19, 2023
b02da51 to
2ffb314
Compare
This will help prevent any regressions and increases our overall coverage.
2ffb314 to
bede3b0
Compare
Member
Author
djc
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds derived
Debugtraits to:BorrowedCertRevocationListBorrowedRevokedCertRevokedCertsSignedDataOwnedCertRevocationListOwnedRevokedCertOwnedSignedDataIt additionally adds derived
Clonetraits to:OwnedCertRevocationListOwnedRevokedCertOwnedSignedData