Skip to content

Bump version to 0.23.16 #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 1 commit into from
Oct 28, 2024
Merged

Bump version to 0.23.16 #2183

djc merged 1 commit into from
Oct 28, 2024

Conversation

@djc
Copy link
Member

@djc djc commented Oct 27, 2024 •
edited
Loading

I don't think there's anything large enough that it's worth calling out here, but I'd like to get #2181 out for the benefit of rustls/rustls-platform-verifier#150. So, proposed release notes highlights:

  • Added support for RFC 7250 raw public keys.

(From #2168, #2173, #2172.)

@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Oct 27, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10723950 10764244 40294 (0.38%) 1.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8587186 8569003 -18183 (-0.21%) 0.57%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10433707 10452358 18651 (0.18%) 1.29%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10749960 10736347 -13613 (-0.13%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3087110 3087621 511 (0.02%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084638 3085031 393 (0.01%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2105878 2105692 -186 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8580267 8581012 745 (0.01%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623390 3623671 281 (0.01%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1210926 1210997 71 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624945 3625148 203 (0.01%) 0.47%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1639805 1639769 -36 (-0.00%) 1.04%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1641170 1641198 28 (0.00%) 1.05%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717476 1717454 -22 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932708 1932686 -22 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30599111 30598894 -217 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30599282 30599075 -207 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 30075875 30075705 -170 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32431449 32431619 170 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 30075546 30075675 129 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30204738 30204615 -123 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30182706 30182586 -120 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30585475 30585377 -98 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30607960 30607872 -88 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32431411 32431499 88 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30218553 30218630 77 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32428537 32428593 56 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30621380 30621432 52 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32425163 32425109 -54 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 30025394 30025434 40 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32428648 32428690 42 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30168406 30168368 -38 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32428152 32428113 -39 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 30022399 30022430 31 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30167974 30167992 18 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7594238 7594234 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183220 35183203 -17 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 30072844 30072856 12 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 30025200 30025189 -11 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30585500 30585511 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348757 58348746 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661845 80661860 15 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389586 46389591 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251822 58251816 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467123 46467127 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68684441 68684445 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718853 92718858 5 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58237091 58237094 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540447 80540444 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256133 58256131 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341602 58341600 -2 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30204109 30204110 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714861 92714859 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434709 46434710 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467813 46467812 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470691 46470692 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487091 46487092 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352504 58352503 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535648 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554935 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641262 80641261 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673768 92673767 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684671 92684672 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42081361 42081361 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460133 46460133 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648883 80648883 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 42646223 42646223 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42053528 42053528 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41570826 41570826 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563544 2563544 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662161 2662161 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41571316 41571316 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 42557498 42557498 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92712623 92712623 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42080821 42080821 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41641024 41641024 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43381775 43381775 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42039583 42039583 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236879 4236879 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292338 11292338 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4251919 4251919 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41640516 41640516 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41654742 41654742 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11452529 11452529 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42095288 42095288 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7596412 7596412 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 42560117 42560117 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3892011 3892011 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 42648831 42648831 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873535 3873535 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480089 46480089 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4694983 4694983 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497663 4497663 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 42560106 42560106 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682833 92682833 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 42648797 42648797 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43381801 43381801 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5014085 5014085 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42039061 42039061 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11458509 11458509 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41585052 41585052 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215889 4215889 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43378656 43378656 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58254053 58254053 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1208556 1208556 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185133 35185133 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925965 1925965 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656296 2656296 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2108813 2108813 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43318866 43318866 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43321985 43321985 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43321981 43321981 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.81 ms 0.02 ms (0.85%) 5.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.79 ms 4.83 ms 0.03 ms (0.67%) 1.36%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.46 ms 4.49 ms 0.03 ms (0.64%) 1.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.81 ms 4.84 ms 0.03 ms (0.61%) 1.74%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.47 ms 5.51 ms 0.03 ms (0.60%) 1.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.53 ms 5.57 ms 0.03 ms (0.59%) 1.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.19 ms 0.03 ms (0.57%) 1.23%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.13 ms 5.16 ms 0.03 ms (0.53%) 1.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.51 ms 5.54 ms 0.03 ms (0.52%) 1.42%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.47 ms 5.50 ms 0.03 ms (0.51%) 1.48%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.60 ms 0.01 ms (0.51%) 1.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.50 ms 0.02 ms (0.43%) 1.83%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.22 ms 0.02 ms (0.39%) 1.67%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.15 ms 5.17 ms 0.02 ms (0.38%) 1.85%
handshake_tickets_ring_1.3_ecdsap256_aes 6.61 ms 6.64 ms 0.02 ms (0.35%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.83 µs 500.11 µs -1.72 µs (-0.34%) 2.38%
handshake_tickets_ring_1.3_rsa_aes 7.11 ms 7.13 ms 0.02 ms (0.33%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 997.48 µs 994.36 µs -3.12 µs (-0.31%) 1.03%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.59 ms -0.01 ms (-0.29%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.29%) 7.70%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.63 ms 0.00 ms (0.28%) 4.30%
handshake_session_id_ring_1.3_ecdsap256_aes 6.51 ms 6.52 ms 0.02 ms (0.27%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.58 ms 6.60 ms 0.02 ms (0.26%) 1.02%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.60 ms -0.01 ms (-0.25%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.84 ms 6.82 ms -0.02 ms (-0.25%) 3.01%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.47 ms 6.49 ms 0.02 ms (0.23%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.74 ms -0.02 ms (-0.23%) 2.53%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.42 ms -0.02 ms (-0.21%) 1.96%
handshake_tickets_ring_1.3_rsa_chacha 7.07 ms 7.09 ms 0.01 ms (0.20%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.33 ms -0.01 ms (-0.20%) 3.27%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.16 ms -0.01 ms (-0.16%) 3.76%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.11 ms -0.00 ms (-0.14%) 9.25%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.43 ms -0.02 ms (-0.12%) 1.38%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.12%) 1.18%
handshake_session_id_ring_1.3_rsa_aes 7.01 ms 7.02 ms 0.01 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.56 ms 9.57 ms 0.01 ms (0.12%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 455.96 µs 455.42 µs -0.54 µs (-0.12%) 3.55%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.03 ms -0.02 ms (-0.11%) 1.21%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.10 ms -0.00 ms (-0.11%) 8.79%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 12.90 ms -0.01 ms (-0.11%) 1.75%
handshake_tickets_ring_1.3_ecdsap384_aes 9.71 ms 9.72 ms 0.01 ms (0.10%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.57 ms 13.56 ms -0.01 ms (-0.10%) 1.46%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.12 ms 5.11 ms -0.00 ms (-0.09%) 3.24%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.09 ms 5.09 ms -0.00 ms (-0.07%) 3.66%
handshake_session_id_ring_1.3_rsa_chacha 6.97 ms 6.98 ms 0.00 ms (0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.68 ms 9.68 ms 0.01 ms (0.07%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms 0.00 ms (0.07%) 1.32%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.93 ms -0.01 ms (-0.06%) 1.46%
handshake_session_id_ring_1.3_ecdsap384_aes 9.60 ms 9.60 ms 0.00 ms (0.05%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 504.14 µs 504.32 µs 0.18 µs (0.04%) 2.75%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.63 ms -0.00 ms (-0.03%) 1.41%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.43 ms -0.00 ms (-0.03%) 4.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.02%) 1.14%
handshake_no_resume_ring_1.2_rsa_aes 989.65 µs 989.82 µs 0.17 µs (0.02%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 457.53 µs 457.58 µs 0.06 µs (0.01%) 2.91%
handshake_no_resume_ring_1.3_rsa_chacha 995.49 µs 995.49 µs 0.00 µs (0.00%) 1.11%

Additional information

Historical results

Checkout details:

@djc djc force-pushed the prepare-0.23.16 branch from 3aba7d2 to 575817f Compare October 27, 2024 19:27
@cpu
Copy link
Member

cpu commented Oct 27, 2024 •
edited
Loading

I'd like to get #2181 out for the benefit of rustls/rustls-platform-verifier#150.

SGTM. I wouldn't mind #2174 in a release for rustls-ffi.

I don't think there's anything large enough that it's worth calling out here,

I think there's a few things worthy of mention in the diff since last release 🤔 . Raw public key support (#2062) and the kyber -> ml-kem (#2175) for example.

@djc
Copy link
Member Author

djc commented Oct 27, 2024

I think there's a few things worthy of mention in the diff since last release 🤔 . Raw public key support (#2062) and the kyber -> ml-kem (#2175) for example.

Ahh. ML-KEM is only in rustls-post-quantum IIUC but raw key support is definitely worth calling out. Stymied again by GitHub sorting PRs by creation date by default...

@codecov
Copy link

codecov bot commented Oct 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (a5d6350) to head (2c8a57b).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2183   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         102      102           
  Lines       23743    23743           
=======================================
  Hits        22475    22475           
  Misses       1268     1268

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpu
Copy link
Member

cpu commented Oct 27, 2024

ML-KEM is only in rustls-post-quantum IIUC

Good point!

@djc
Copy link
Member Author

djc commented Oct 27, 2024

Added a line about the raw public keys.

@cpu
Copy link
Member

cpu commented Oct 27, 2024

I think the fuzz crate lock file needs an update to fix ci

@djc djc force-pushed the prepare-0.23.16 branch 2 times, most recently from cf0d14c to 9721c6e Compare October 28, 2024 09:23
@djc djc force-pushed the prepare-0.23.16 branch from 9721c6e to 2c8a57b Compare October 28, 2024 10:02
@djc djc merged commit 276eb74 into main Oct 28, 2024
@djc djc deleted the prepare-0.23.16 branch October 28, 2024 13:15
@djc
Copy link
Member Author

djc commented Oct 28, 2024 •
edited
Loading

(Bypassed the merge queue to deal with the semver compatibility issue.)

  • Published rustls v0.23.16 at registry crates-io
  • [new tag] v/0.23.16 -> v/0.23.16
  • Release notes

@stormshield-gt
Copy link
Contributor

stormshield-gt commented Nov 4, 2024

In the release note, it's mentioned that we moved from kyber768 to ML-KEM768 for rustls-post-quantum but this change is not published yet. Maybe a 0.2 version of rustls-post-quantum could be published? Or we are waiting on #2136 ?
I'm currently migrating to post-quantum, It would be better for me to directly migrate to ML-KEM rather than a 2-step process. Note that I'm fine with waiting, though.

@ctz
Copy link
Member

ctz commented Nov 4, 2024

Yes I would like to land #2136 before releasing the next rustls-post-quantum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpu cpu cpu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@djc @cpu @stormshield-gt @ctz