Recreate README.md as a non-symlink#250
Merged
cfvescovo merged 1 commit intorust-scraper:masterfrom Jun 11, 2025
Merged
Conversation
|
This solves the issue that on macOS you get: |
Member
|
Weird, LGTM though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q: You just deleted and recreated it? In a single commit?! What the heck?
Ah yeah, I was just pinged by my one of my colleagues who had a problem when checking out this repository and found there's a weirdness. That the main
README.mdand thescraper/README.mdare both symlinks! Except the latter is not really supposed to be a symlink but a file. Still you can see it still being a symlink from GitHub:My PR fixes it:
But what about the git blame?
Only my commit will appear for every line, but not sure there's a better way. There should be, I'm just not aware of it.
So what did you actually do?
I deleted the file, committed it, recreated one, committed it again, and squashed those two commits. Git shows "typechange" when you run
git commit --amendon top of my commit:But git still thinks I created every line when you run git blame. Huh.