Conversation
|
I guess removing |
dhardy
left a comment
There was a problem hiding this comment.
Looks good.
The minimal-dependency-version test isn't much use then, is it? But some people want it (unless it's fallen out of fashion; I haven't heard much about this for a while).
Should we require a newer version of serde, if 1.0.103 is not working correctly? |
|
Do we need |
|
Should there be a changelog entry? If yes where? |
It was actually serde_json which is only a dev dependency. So I have bumped the version. I think it is still sensible to check if the minimal version requirements work. For us having different crates in the same workspace leads to false negatives on it as we have seen here. |
Yes (it's used by
No; it's not a change to any crate. |
dhardy
left a comment
There was a problem hiding this comment.
Looks good.
The ziggurat tables should probably only be in rand_distr.
I think it's just this to do.
CHANGELOG.mdentrySummary
#1394
Details
It removes all of the code which now lives in the rand_distr repository