Merged
Conversation
newpavlov
approved these changes
Nov 27, 2024
Member
newpavlov
left a comment
There was a problem hiding this comment.
Clippy and rustfmt both now run on rustc stable.
Clippy routinely gets new lints. So using the stable toolchain can result in unrelated CI failures on new stable releases. This is why I think it's worth to keep a fixed version and bump it manually from time to time.
Member
Author
|
I know; I've been hit by a few that appeared on nightly (often being adjusted before hitting stable). But I suspect we will forget to update this otherwise, and we would need to specify in three places. |
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweak the GH Actions:
benchesjob. This is more logical. It does mean we need to run that job on changes to the main source tree, but that's not a big deal IMO since the Clippy/rustfmt jobs are very fast.distr_test