Merged
Conversation
Member
Author
|
CI fails due to using an old version of @TheIronBorn review? |
Contributor
|
with 1.51 we could stabilize the |
Contributor
|
Otherwise I think this is fine. |
Member
Author
|
Rebased. @TheIronBorn could you please formally approve and merge this PR? Our branch protection requires approval from a maintainer other than the PR author. |
TheIronBorn
approved these changes
Aug 14, 2022
Merged
dhardy
added a commit
that referenced
this pull request
Nov 10, 2022
* examples/rayon-monte-carlo.rs: remove execute bit of file metadata * Document in README that MSRV is 1.51.0 This was changed in #1246 * Update GitHub Actions
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
* examples/rayon-monte-carlo.rs: remove execute bit of file metadata * Document in README that MSRV is 1.51.0 This was changed in rust-random#1246 * Update GitHub Actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want at least 1.38.0 to avoid complicating our CI: crossbeam-rs/crossbeam#877
... but anything over 1 year should be fine. 1.51.0 allows us to drop the
min_const_genfeature. I didn't see a reason to go any more recent yet.(This won't affect releases until 0.9.0.)