add more brainpool curve NID constants#2567
Merged
botovq merged 3 commits intorust-openssl:masterfrom Feb 3, 2026
Merged
Conversation
7fe9d26 to
c7d57cb
Compare
botovq
reviewed
Jan 27, 2026
Contributor
botovq
left a comment
There was a problem hiding this comment.
Generally ok with this with my review comments addressed.
We'll have to fix the CI after the latest Rust update before we can land this, though.
Contributor
Author
|
Do you require help with fixing the CI? I would not mind fixing the clippy issues myself at least. |
Collaborator
|
I think we need a ctest release: rust-lang/libc#4831 |
Collaborator
|
CI should be fixed now. |
Contributor
|
Please rebase on top of master. I'll approve and merge if the CI is green. |
22619fa to
61906a9
Compare
Contributor
Author
|
my bad! sorry |
botovq
approved these changes
Feb 2, 2026
Contributor
botovq
left a comment
There was a problem hiding this comment.
Looks like the CI will take a while. I think this is good to merge and will do it after sleep if nobody beats me to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more NID constants for additional brainpool curves defined in RFC5639, which are available in openssl, but not rust-openssl.
These curves included are: