Skip to content

Bump minimum OpenSSL version to 1.0.2#2491

Merged
alex merged 1 commit intorust-openssl:masterfrom
alex:min-openssl-1.0.2
Oct 14, 2025
Merged

Bump minimum OpenSSL version to 1.0.2#2491
alex merged 1 commit intorust-openssl:masterfrom
alex:min-openssl-1.0.2

Conversation

@alex
Copy link
Collaborator

@alex alex commented Oct 13, 2025

🤖 Generated with Claude Code

botovq
botovq reviewed Oct 13, 2025
View reviewed changes
@botovq
Copy link
Contributor

botovq commented Oct 13, 2025

Of course the 1.0.1 CI needs to go away.

I wonder if a generic #[cfg(openssl)] would make sense. I would expect that 1.0.2 and 1.1.0 will be dropped in the not too distant future and this would avoid some version churn.

@alex
Copy link
Collaborator Author

alex commented Oct 13, 2025

I think there's already a cfg(openssl), but it's also set on LibreSSL for whatever historic reason.

@alex alex force-pushed the min-openssl-1.0.2 branch from d237942 to 7fea052 Compare October 13, 2025 21:07
@botovq botovq mentioned this pull request Oct 13, 2025
Merged
@alex alex force-pushed the min-openssl-1.0.2 branch from 7fea052 to a3e36a3 Compare October 13, 2025 21:23
botovq
botovq reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@botovq botovq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good but it's too late for me to check this in full detail.

botovq
botovq approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@botovq botovq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few user-visible lines still mention 1.0.1 of which at least these seem worth fixing:

rust-openssl/openssl/src/lib.rs

Line 3 in f5e04e2

//! This crate provides a safe interface to the popular OpenSSL cryptography library. OpenSSL versions 1.0.1 through

rust-openssl/openssl/src/ec.rs

Lines 296 to 297 in f5e04e2

/// This defaults to `EXPLICIT_CURVE` in OpenSSL 1.0.1 and 1.0.2, but `NAMED_CURVE` in OpenSSL
/// 1.1.0.

rust-openssl/openssl/src/ssl/connector.rs

Lines 65 to 66 in f5e04e2

/// OpenSSL's built-in hostname verification is used when linking against OpenSSL 1.0.2 or 1.1.0,
/// and a custom implementation is used when linking against OpenSSL 1.0.1.

@alex @claude
Bump minimum OpenSSL version to 1.0.2
327f8b4 
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@alex alex force-pushed the min-openssl-1.0.2 branch from a3e36a3 to 327f8b4 Compare October 14, 2025 11:10
@alex
Copy link
Collaborator Author

alex commented Oct 14, 2025

I ended up being able to rip out a bunch of hostname verification code that shouldn't be required anymore.

botovq
botovq approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@botovq botovq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, I was going to look into what that was all about. Glad you beat me to it!

@alex alex merged commit 0c59ab0 into rust-openssl:master Oct 14, 2025
161 of 162 checks passed
@alex alex deleted the min-openssl-1.0.2 branch October 14, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@botovq botovq botovq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex @botovq