feat: add an extra method to (Checked)Euclid trait to get both quotien and rem#291
Merged
bors[bot] merged 4 commits intorust-num:masterfrom Oct 25, 2023
Merged
Conversation
cuviper
requested changes
Oct 12, 2023
Member
cuviper
left a comment
There was a problem hiding this comment.
I suggested some fixes for the documentation. I would also appreciate some tests, and doc-examples are an easy way to both demonstrate the feature and test it.
I think we should drop "with" from the name, just div_rem_euclid and checked_div_rem_euclid. This will be more similar to Integer::div_rem.
Contributor
Author
|
@cuviper it's ready for another review |
cuviper
reviewed
Oct 18, 2023
Contributor
Author
|
@cuviper Ready for review |
cuviper
reviewed
Oct 25, 2023
Member
|
Thanks! bors r+ |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #290