Skip to content

Add derive macro for num_traits::Signed#55

Merged
bors[bot] merged 3 commits into
rust-num:masterfrom
tdelabro:add-derive-Signed
Oct 7, 2023
Merged

Add derive macro for num_traits::Signed#55
bors[bot] merged 3 commits into
rust-num:masterfrom
tdelabro:add-derive-Signed

Conversation

@tdelabro

@tdelabro tdelabro commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@tdelabro

tdelabro commented Jul 5, 2023

Copy link
Copy Markdown
Contributor Author

@cuviper Do you think this could be merged?

@cuviper

cuviper commented Jul 5, 2023

Copy link
Copy Markdown
Member

Would you be willing to write a corresponding newtype-derived Unsigned as well? That one is just a marker type, but it could still be useful to have #[derive(Unsigned)], just like you can with the Copy marker.

@tdelabro

tdelabro commented Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

Sure. I will in the next days

@tdelabro

Copy link
Copy Markdown
Contributor Author

Hey, @cuviper. Sorry it took so long, I got really busy with my job.

Here it is tho :)

@tdelabro

tdelabro commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

@cuviper ping

@cuviper cuviper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things in the tests...

Comment thread tests/newtype.rs Outdated
Comment thread tests/newtype.rs Outdated
@cuviper

cuviper commented Oct 7, 2023

Copy link
Copy Markdown
Member

bors r+

@bors

bors Bot commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors Bot merged commit 2c5013e into rust-num:master Oct 7, 2023
@tdelabro tdelabro deleted the add-derive-Signed branch October 9, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants