Skip to content

Update to syn-2#54

Merged
bors[bot] merged 6 commits into
rust-num:masterfrom
maurer:syn-update
Jun 30, 2023
Merged

Update to syn-2#54
bors[bot] merged 6 commits into
rust-num:masterfrom
maurer:syn-update

Conversation

@maurer

@maurer maurer commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Also moves a test out of doctest compilefail since syn-2 will build it correctly even without the "full" feature.

@cuviper

cuviper commented Mar 23, 2023

Copy link
Copy Markdown
Member

Do we use anything that would need "full" anymore? If not, I think we should just drop that feature. We can bump semver for the new MSRV requirement while we're at it, so a breaking feature change is ok.

Comment thread src/lib.rs Outdated
maurer added 2 commits March 23, 2023 23:45
Also moves a test out of doctest compilefail since syn-2 will build it
correctly even without the "full" feature.
The primary use-case of full-syntax (complex discriminants) is now
covered by syn even without full, so this feature is unnecessary.

Since bumping the MSRV for syn to 1.56 is a breaking change, we can drop
the full-syntax feature at the same time.
@maurer

maurer commented Mar 23, 2023

Copy link
Copy Markdown
Contributor Author

I fixed up the .unwrap() call and added an additional commit to remove the full-syntax feature. There are still some things that are not present in syn without full, but none of them seem to correspond to complex discriminants.

@glandium

glandium commented Jun 6, 2023

Copy link
Copy Markdown

@cuviper is there anything holding this up?

@cuviper

cuviper commented Jun 30, 2023

Copy link
Copy Markdown
Member

bors r+

@bors

bors Bot commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors Bot merged commit fce481d into rust-num:master Jun 30, 2023
@cuviper

cuviper commented Jun 30, 2023

Copy link
Copy Markdown
Member

is there anything holding this up?

Lack of time and attention... but it's published now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants