Should I also simplify it for the existing custom flag?

No, because that is used with the all feature being enabled, that's the reason the code is written the way it is.

Should I also simplify it for the existing custom flag?

No, because that is used with the all feature being enabled, that's the reason the code is written the way it is.

I don't get it sorry. Also I put the new function with the all feature flag too, should I remove it?

@DBLouis you need to revert all changes to _no_inherit and no_inherit. We do it this way because no_inherit should only be public if the all feature is set. However, internally we also use the function, so we added _no_inherit that is always available.

That makes sense. So I revert the changes for no_inherit, but for registered-io I keep only one function. Should it be feature gated though? It is a windows only flag and a bit niche.

Should it be feature gated though? It is a windows only flag and a bit niche.

That's exactly why it should be feature gated.

Is it all good now? Please tell me if it needs more work :)

I have added a test. It ran successfully 😁

Thanks @DBLouis!