Add v4 and v6 versions of bind_device_by_index.#432
Merged
Thomasdezeeuw merged 1 commit intorust-lang:masterfrom May 29, 2023
Merged
Add v4 and v6 versions of bind_device_by_index.#432Thomasdezeeuw merged 1 commit intorust-lang:masterfrom
Thomasdezeeuw merged 1 commit intorust-lang:masterfrom
Conversation
5d3296b to
975f678
Compare
975f678 to
f45c480
Compare
Collaborator
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
One last thing I missed in the first review round.
koalamay
approved these changes
May 11, 2023
f45c480 to
dc576c8
Compare
Thomasdezeeuw
approved these changes
May 23, 2023
Collaborator
|
@pinkisemils if you apply my suggested changes it should fix the CI. |
4d1e699 to
5262f5f
Compare
Collaborator
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Sorry, I messed up the doc links the first time. I tried pushing to the branch, but GitHub wouldn't allow me.
src/sys/unix.rs
Outdated
| .map(|_| ()) | ||
| } | ||
|
|
||
| /// This method is deprecated, use [`Socket2::bind_device_by_index_v4`]. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// This method is deprecated, use [`Socket2::bind_device_by_index_v4`]. | |
| /// This method is deprecated, use [`Socket::bind_device_by_index_v4`]. | |
| /// | |
| /// [`Socket::bind_device_by_index_v4`]: crate::Socket::bind_device_by_index_v4 |
src/sys/unix.rs
Outdated
| Ok(NonZeroU32::new(index)) | ||
| } | ||
|
|
||
| /// This method is deprecated, use [`Socket::device_index_v4`]. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// This method is deprecated, use [`Socket::device_index_v4`]. | |
| /// This method is deprecated, use [`Socket::device_index_v4`]. | |
| /// | |
| /// [`Socket::device_index_v4`]: crate::Socket::device_index_v4 |
5262f5f to
28d6de7
Compare
Collaborator
|
Thanks for sticking with this @pinkisemils, sorry it took a little while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added IPvX versioned functions for
bind_device_by_indexand deprecated the original, as discussed in #413.I've added a change log entry (and thus tentatively declaring a new verison), but I'm unsure if that's the correct thing to do here.