Match the standard library's interface for unix sockets on unix.#403
Merged
Thomasdezeeuw merged 17 commits intorust-lang:masterfrom Mar 4, 2023
Merged
Match the standard library's interface for unix sockets on unix.#403Thomasdezeeuw merged 17 commits intorust-lang:masterfrom
Thomasdezeeuw merged 17 commits intorust-lang:masterfrom
Conversation
to enable determining what type of AF_UNIX address it is, if any. Enable retrieving the pathname or abstract address of the socket, if applicable. Also, fix some typos in CONTRIBUTING.
aviramha
reviewed
Feb 27, 2023
Thomasdezeeuw
approved these changes
Mar 2, 2023
Collaborator
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
LGTM. Only question is Fuchsia, we might have to remove it for now (sorry for suggesting it in the first place).
Collaborator
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
One final suggestion based on @tamird and @ghanan94's feedback.
Co-authored-by: Thomas de Zeeuw <thomasdezeeuw@gmail.com>
Collaborator
|
Thanks @t4lz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #332, currently unix only. Should this interface also be made available on Windows?
This PR adds to
SockAddrmethods to get the path of the unix socket address on unix.It also adds the new methods to the tests.